dumux issueshttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues2021-10-01T12:36:42Zhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1013SimpleH20 does not consider enthalpy of vaporization2021-10-01T12:36:42ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deSimpleH20 does not consider enthalpy of vaporizationI suggest to add $`h_\mathrm{vap}`$ here:
```c++
static const Scalar gasEnthalpy(Scalar temperature,
Scalar pressure)
{
static const Scalar tRef = getParam<Scalar>("SimpleH2O.Reference...I suggest to add $`h_\mathrm{vap}`$ here:
```c++
static const Scalar gasEnthalpy(Scalar temperature,
Scalar pressure)
{
static const Scalar tRef = getParam<Scalar>("SimpleH2O.ReferenceTemperature", 293.15);
return gasHeatCapacity(temperature, pressure)*(temperature - tRef) + 2453.5e3;
}
```
We could even make $`h_\mathrm{vap}`$ depending on $`T_\mathrm{ref}`$ as there as simple equations for that.
http://www.personal.psu.edu/users/m/r/mrh318/physical-consts/Popiel-Wojtkawiak-HTE-1998.pdf
https://www.scirp.org/pdf/AS20120200008_25514260.pdf (Bananas!)
It would still be a constant.3.5https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/1000Properly include the volume work term in the energy balance2021-09-29T08:55:26ZKilian Weishauptkilian.weishaupt@iws.uni-stuttgart.deProperly include the volume work term in the energy balanceWe currently implement
$`\frac{\partial}{\partial t}(\rho u) = - \nabla \cdot (\rho \mathbf{v}h) + \nabla \cdot (\lambda \nabla T)`$
with $`h = u + \frac{p}{\rho}`$
However, the correct form of the energy balance equation is (see !2...We currently implement
$`\frac{\partial}{\partial t}(\rho u) = - \nabla \cdot (\rho \mathbf{v}h) + \nabla \cdot (\lambda \nabla T)`$
with $`h = u + \frac{p}{\rho}`$
However, the correct form of the energy balance equation is (see !2473, !2471)
$`\frac{\partial}{\partial t}(\rho u) = - \nabla \cdot (\rho \mathbf{v}u) -p \nabla \cdot \mathbf{v} + \nabla \cdot (\lambda \nabla T)`$
Replacing enthalpy with internal energy in the first divergence term is simple but
the discretization of
$`p \nabla \cdot \mathbf{v}`$
is not straight-forward.
A possible simple solution would be:
Include in calculation of flux terms, i.e., evaluate $`\nabla \cdot \mathbf{v}`$
and assume a cell-constant $`p`$ which is just multiplied to the term. This gives a first-order scheme but should be ok since the term is often small. For incompressible flow the term also vanishes discretely since $`\nabla \cdot \mathbf{v} = 0`$.
This seems to work for cell-centered schemes without much additional effort (!2494).
For the box method it seems more difficult since the code assumes that fluxes on scvfs are symmetric. However the energy contribution (assembled on the scvfs) is different depending on the control volume (different control volume pressure).https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/988[Forchheimer] Does this work for multi-phase flow?2021-07-20T09:14:16ZDennis GlĂ¤ser[Forchheimer] Does this work for multi-phase flow?In !2414, @martins and I discussed if Forchheimer (or our implementation of it) works for multi-phase settings. It is permitted in the code and, but some variables have names that suggest one-phase flow regimes. Moreover, there is this c...In !2414, @martins and I discussed if Forchheimer (or our implementation of it) works for multi-phase settings. It is permitted in the code and, but some variables have names that suggest one-phase flow regimes. Moreover, there is this comment:
```cpp
// This is important in the case of a one-phase region in two-phase flow. The non-existing
// phase has a velocity of zero (kr=0).
```
see line 472 in https://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/blob/59ee4e5e26d6646dcf7670df8b4f7193a6fe3fda/dumux/flux/cctpfa/forchheimerslaw.hhRoman WinterRoman Winterhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/970Check brine fluidsystem2021-07-28T09:00:55ZTheresa SchollenbergerCheck brine fluidsystemThe binary diffusion coefficient of NaCl seems to be wrong. Also there is no source available for the implemented one. Because of that the implemented parameters should be checked and sources sould be added.
Further there are relations e...The binary diffusion coefficient of NaCl seems to be wrong. Also there is no source available for the implemented one. Because of that the implemented parameters should be checked and sources sould be added.
Further there are relations e.g. for density where the source is not mentioned in the comments. Also there are some todos left to do which could be essential.
- [x] correct diffusion coefficient
- [ ] check parameters and add sources
- [ ] improve comments and add sources for relationships
- [ ] todo check contribution of NaCl on thermal conductivity
- [ ] todo find better description for calculation of the isobaric heat capacity
- [x] check solid heat capacity of NaCl which is given in J/mol K3.5Theresa SchollenbergerTheresa Schollenbergerhttps://git.iws.uni-stuttgart.de/dumux-repositories/dumux/-/issues/690[material][co2] create co2 tables with pressures less than 1 bar2021-07-20T09:14:51ZKatharina Heck[material][co2] create co2 tables with pressures less than 1 barthe current co2 tables start at 1 bar pressure but in the fluidsystems e.g. brineco2 we calculate e.g. the gas density based on partial pressure (which can be less than 1 bar). That can lead to wrong results if the partial pressure is le...the current co2 tables start at 1 bar pressure but in the fluidsystems e.g. brineco2 we calculate e.g. the gas density based on partial pressure (which can be less than 1 bar). That can lead to wrong results if the partial pressure is less than 1 bar. Then the value of 1 bar is taken from the table and added to the density calculation (which is especially wrong if no co2 is present at all)
Possibly this could be a task for a Hiwi to look into a meaningful relationship for densities etc for co2 and create new tables.3.5Johannes HommelJohannes Hommel